Scheduler: T1310524 — shadeUntilCurrentTime property is inconsistently applied to resources outside the viewport in virtual scrolling mode#32187
Merged
Tucchhaa merged 9 commits intoDevExpress:26_1from Jan 16, 2026
Conversation
…cchhaa/DevExtreme into shade_until_current_time_26_1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue T1310524 regarding inconsistent application of the shadeUntilCurrentTime property to resources outside the viewport in virtual scrolling mode for the Scheduler component.
Changes:
- Removed the
getRoundedCellWidthmethod from the workspace class, which was calculating cell widths based on actual DOM measurements across groups - Refactored
getIndicationWidthandgetIndicatorOffsetmethods to no longer acceptgroupIndexparameter and instead use a consistentgetCellWidth()value - Renamed
_getIndicatorDurationto_getIndicatorDaysSpanfor better clarity - Updated all method call sites to remove the
groupIndexparameter - Added new TestCafe end-to-end tests specifically for virtual scrolling scenarios
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts |
Removed the getRoundedCellWidth method that was calculating cell widths based on DOM measurements |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts |
Refactored width/offset calculations to use consistent cell width values instead of group-specific measurements; renamed _getIndicatorDuration to _getIndicatorDaysSpan |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts |
Updated calls to getShaderWidth and removed group index parameters from getCellWidth calls |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_vertical.ts |
Updated call to getIndicationWidth to match new signature |
packages/devextreme/js/__internal/scheduler/shaders/m_current_time_shader_vertical.ts |
Updated _getShaderWidth calls to not pass group index parameter |
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/currentTimeIndicator.tests.js |
Updated QUnit tests to use getCellWidth() instead of getRoundedCellWidth(1) or getRoundedCellWidth(0) |
e2e/testcafe-devextreme/tests/scheduler/common/layout/timeIndication/shaderVirtualScrolling.ts |
Added new TestCafe tests to verify shader rendering with virtual scrolling in different scroll positions |
...es/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts
Show resolved
Hide resolved
...es/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts
Show resolved
Hide resolved
sjbur
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.